On 08/31/11 12:43, Jesse Butler wrote:
I think it might be cleaner to initialize 'start_addr' to None, then
set it first time through the loop, rather than using
the 'first_client_addr' variable.
Good idea. I'll do that.
Also, I find that loop starting on 151 to be a bit clunky... maybe
worthy of a comment just to make it bit more clear.
I will add some more comments.
Otherwise, all good.
/jb
On Aug 30, 2011, at 5:36 PM, Harold Shaw wrote:
Can I get a couple of reviews of the changes for:
7082285 <http://monaco.us.oracle.com/detail.jsf?cr=7082285>
/usr/sbin/installadm-convert dumps traceback with IndexError code
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/hshaw/7082285/webrev/
To verify the fix the following DHCP configurations were run:
- Single IP address
- Single IP range
- Mixture of single IP addresses and IP ranges
Thanks,
Harold
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
