On 01/09/2011 23:04, Karen Tung wrote: > Hi Jack, > > Here are my comments. > > General: > ------------ > > The SVR4 admin file is just a few lines of key value pairs. > It's not something the user can customize, at this time, at least. > Is it really necessary to deliver a file? Why not put all > these key value pairs into a static dictionary in the svr4.py > file, and create the file at execution time. > This have the advantage of having everything the svr4.py module > uses in 1 single place. It also have the advantage > simplifying all the code in lines 473-496 of svr4.py, since > you can just add or reset of the value of the "proxy" key, > before writing out the file.
There should be no need to set the proxy variable, since the AI manifest contains a http_proxy setting, and this results in the environment variable "http_proxy" being set, which should suffice for pkgadd. Thanks, Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
