On 09/02/11 09:59, Dave Miner wrote:
On 09/02/11 12:28, Ethan Quach wrote:
It just seemed wrong for an underlying module/library to assume it
should be writing to stdout for its caller.
I agree with that as a general rule, but when the majority of uses are
in opposition to the default, that usually means the default is wrong.
I suppose we could turn it to true by default and make sure all callers
who don't want it to explicitly pass in false. Is it your preference
for us to do that? If so, I can do a little bit more testing and make
that change.
The additional testing is for:
a) DC also uses the TransferIPS checkpoint for the set-ips-attributes
step, which my current changes don't turn on this output for.
b) The TransferP5I class is a subclass of TransferIPS.
I'd just have to make sure these two usages with output turned on won't
do anything weird.
-ethan
But also, the GZ auto-install use case is not using this feature.
At least not yet :-)
-ethan
On 09/02/11 09:21, Dave Miner wrote:
There's nothing really wrong here, but I'm not sure I get why you
defaulted show_stdout to false when it seems that all of our uses want
it to be true.
Dave
On 09/02/11 11:55, Ethan Quach wrote:
Can I please get a couple of reviewers for this fix:
Webrev:
----------
https://cr.opensolaris.org/action/browse/caiman/equach/7086390/webrev/
BugID:
--------
7086390 <http://monaco.us.oracle.com/detail.jsf?cr=7086390> Turn on
transfer/ips phase output for DC
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
