Ok, thanks.
On 06/09/2011 09:22, William Schumann wrote:
> Dermot,
> On 9/5/2011 2:38 PM, Darren Kenny wrote:
>> Hi William,
>>
>> Looks good, only one comment about the error in ip_address.py:
>>
>> 148 + raise ValueError("No leading zeros")
>>
>> I think this can be misinterpreted, and probably would probably read better
>> as
>> something like:
>>
>> "Leading zeros are not permitted in address segments: %s" % segment
> All of the validation messages from this module are overridden by a more
> generic message - the user never sees them, only the pyunit tests. If
> these messages ever do go live, they should be reevaluated at once.
> Thanks,
> William
>> Thanks,
>>
>> Darren.
>>
>> On 05/09/2011 12:58, William Schumann wrote:
>>> 7073565 snv_169 text installer: edited numeric fields eat the Escape
>>> sequences
>>> <http://monaco.us.oracle.com/detail.jsf?cr=7073565>
>>> The original bug has been fixed - the bug report also mentions that leading
>>> zeros, accepted as valid by TI, cause problems with some applicaitions.
>>> Modified validator to reject leading zeros. Added unit test for leading
>>> zeros,
>>> modified another unit test to check for non-numeric characters only.
>>>
>>> Also encountered bug during testing - the DNS domain should be required
>>> (occurs
>>> since DNS and NIS domain screens were separated). At least one DNS domain
>>> is
>>> required in the fix.
>>>
>>> https://cr.opensolaris.org/action/browse/caiman/wmsch/7073565/webrev/
>>>
>>> Thank you,
>>> William
>>> //<http://monaco.us.oracle.com/detail.jsf?cr=7073565>
>>>
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> [email protected]
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
