Hi Sue,
Thank you for the code review. I removed the continuation characters as
you suggested.
--Karen
On 09/ 7/11 10:15 AM, Sue Sohn wrote:
Hi Karen,
Also, in controller.py, there is no need for continuation characters
on lines 626 and 627.
Otherwise, looks good.
Sue
On 09/07/11 10:13, Karen Tung wrote:
Thank you for the code review John. I changed the error message
in both files as you suggested below.
Thanks,
--Karen
On 09/ 7/11 10:05 AM, John Fischer wrote:
Karen,
Looks good to me too. I would only change the wording:
206 err_msg = "There should only be 1 gap in
partition" \
207 " %s, but %d gaps are found." % \
to:
err_msg = "There should only be 1 gap in partition" \
" %s, but %d gaps were found." % \
Keep up the great work.
John
On Sep 7, 2011, at 9:58 AM, Drew Fisher wrote:
Karen,
This looks good to me. Can you verify that the targets and AI
unittests still run correctly?
-Drew
On 9/7/11 10:50 AM, Karen Tung wrote:
Good morning,
I would like a couple of reviewers to look at my changes for the
following bugs.
7087586 <http://monaco.us.oracle.com/detail.jsf?cr=7087586>
Problems with target controller applying the wrong default layout
7087182 <http://monaco.us.oracle.com/detail.jsf?cr=7087182> S11
text installer crashes ("Desired target doesn't pass final
validation") for empty 0xbf partition
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/partition-bugs/webrev/
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
