LGTM, Niall. -Drew
On 9/19/11 8:19 PM, Niall Power wrote:
Hi, I'd like to ask for a couple of reviews for this small fix for CR 7092589 *Synopsis*: livecd enable-ssh grub menu disappear in snv_166 and onward for livecd Bugster:http://bt2ws.central.sun.com/loadcr.jnlp?jnlp_url=http://bugster.central.sun.com/&arg=7092589 CrPrint:http://bt2ws.central.sun.com/CrPrint?id=7092589 Monaco:http://monaco.sfbay.sun.com/detail.jsf?cr=7092589 The "Enable SSH" option has been missing from the LiveCD image. This fix adds it back and also adds a test case to capture it. I also included a one line fix for a broken test case caused by an unnecessary file deletion (the file name changed in the original code but it is unnecessary to delete it explicitly since it gets cleaned up later along with its parent directory anyway) Webrev: https://cr.opensolaris.org/action/browse/caiman/niall/7092589/webrev-7092589/ Thanks, Niall _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
