Thanks John.  I can fix that.

-ethan

On 09/22/11 15:58, John Fischer wrote:
Ethan,

Looks good.  Just to be consistent can you remove the space between the
-f and the 2 below:

  138                         IPADDR=$($GREP "^root_server" $WANBOOT_CONF | \
  139                                 $CUT -d '=' -f 2 | $CUT -d'/' -f3 | \
  140                                 $CUT -d':' -f1)

No second review necessary.

Thanks,

John

On Sep 22, 2011, at 3:53 PM, Ethan Quach wrote:

Team,

Can I get a couple of reviewers for the following bugfix:


Webrev:
----------
https://cr.opensolaris.org/action/browse/caiman/equach/7093471/webrev/

BugID:
--------
7093471 <http://monaco.us.oracle.com/detail.jsf?cr=7093471> wanboot without DHCP not working


Cases tested:
-----------------
1. Sparc, wanboot with DHCP, wanboot.conf has IP address in 'root_server'
2.  Sparc, wanboot with DHCP, wanboot.conf has hostname in 'root_server'
3. Sparc, wanboot without DHCP, wanboot.conf has IP address in 'root_server' 4. Sparc, wanboot without DHCP, wanboot.conf has hostname in 'root_server'


thanks,
-ethan

_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to