On 09/23/11 11:24 AM, Jack Schwartz wrote:
Hi Karen.

Changes LGTM.

About generating sparc sort files, there is a way of specifying options to OBP, as we specify "install" to start the installer. Could we not implement some other option for sorting using that mechanism? That can be another bug though.
Hi Jack,

Thank you for the code review.

I know there's a way to specify options to OBP, and we have code that interprets OBP options. However, the live-io-tracing script currently does not have code to interpret any OBP options. I can file a P4 RFE to track this improvement to the live-io-tracing
script if we ever want to generate iso sort files for sparc.

Thanks,

--Karen

    Thanks,
    Jack

On 09/23/11 12:26 AM, Karen Tung wrote:
Hi everyone,

I am looking for 2 reviewers for my changes for:

7078753 <http://monaco.us.oracle.com/detail.jsf?cr=7078753> Time to redo livecd.sort and text_x86.sort 7094112 <http://monaco.us.oracle.com/detail.jsf?cr=7094112> Text installer boot up shows error about /usr/xpg4/bin/awk not found

webrev:

https://cr.opensolaris.org/action/browse/caiman/ktung/new-iso-sort/webrev/

Note:

I didn't make any changes to system-library-boot-management.mf for fixing
the 2 bugs above. This file appears on the webrev because I had to run pkgfmt
on it.  The gate does not build if I don't run pkgfmt on it.

Testing:

- I built Live CD and text installer x86 images with the updated iso sort files.
- I booted up the Live CD and make sure the install is successful.
- I booted up the text installer and made sure the error about /usr/xpg4/bin/awk no longer shows up,
and I went through the install to make sure there's no regression.

Thanks,

--Karen
-


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to