On 09/30/11 13:46, Karen Tung wrote:
On 09/30/11 12:25 PM, Susan Sohn wrote:
On 09/29/11 04:40 PM, Karen Tung wrote:
Hi,

I would like to get a couple of reviews for my simple change for the following bug:

7096046 <http://monaco.us.oracle.com/detail.jsf?cr=7096046> text install still show build number


webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/7096046/webrev/

Testing:

I ran the updated script in a booted image and made sure the build number
doesn't show up, and everything else look good.

Thanks,

--Karen


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Hi Karen,

The code looks ok. I am just wondering if there will be a problem because you are changing the output string, as we are not supposed to be changing them at this point.

Sue
Hi Sue,

Thank you for the review. I don't know whether this will be a problem or not. I am going to send email to Takashi and ask for his opinion, and I will respond
again when I get more data.

Thanks,

--Karen

Hi Sue,

I heard from Takeshi on this.  He says that the change I am making
should be OK since the menu of 5 items from the text installer image
is currently not translated.

Thanks,

--Karen

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to