On 10/18/11 05:57, Jan Damborsky wrote:
Hi Drew,
when testing some corner cases, I realized why manifest was generated in
on_continue() function. When user quits SCI tool prematurely, SC profile
should
not be generated, since it may be incomplete.
So I have modified the fix to take that scenario into account. on_continue()
signals completeness to caller via raising dedicated exception and
caller initiates
process of generating SC profile only when that exception is raised.
This seems unusual, Jan.
Exceptions are generally expected to be used for error situations, not
as a normal control flow. Shouldn't we instead be generating exceptions
when the screen parade is exited prior to summary and then using a
normal exit status as the indication of a completed profile?
Dave
Could I please ask you to take a look at modified webrev ?
incremental:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7066863-1-diff/webrev-1-diff/
full:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7066863-1/webrev-1/
Thank you very much,
Jan
On 10/17/11 15:07, Drew Fisher wrote:
Jan,
This looks ok to me. One question though: Where do you execute the
ManifestWriter checkpoint now that the on_continue() method has been
removed from summary.py?
-Drew
On 10/17/11 6:58 AM, Jan Damborsky wrote:
Hi Ginnie, Drew,
could I please ask you to review couple of sysconfig bug fixes for
following CRs ?
7066863 'sysconfig create-profile' in a ROZR zone causes a traceback
7099567 InstallLogger.__init__() manipulates incorrect dir for other
than DEFAULTLOG file
7097639 sysconfig configure -c file.xml generates stack trace due to
path not including . and /usr/sbin
7079796 sysconfig create-profile is silent about write failures
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7066863/webrev/
Those fixes target U1 (not S11FCS).
Thank you,
Jan
tests done:
[1] regression tests
* built all install images (Sparc, x86) using modified Distribution
Constructor
* tested AI, text installation, GUI installation
[2] CR specific tests
* 7097639
- in ROZR zone booted in writable mode, successfully run
'sysconfig configure -c<profile>' withPATHunset.
Following tests done in ROZR zone booted in read-only mode:
* 7066863
- 'sysconfig create-profile' didn't generate traceback
- log file was redirected /system/volatile/sysconfig.log
- SC profile created in /system/volatile/profile/sc_profile.xml
* 7099567
- verified that logger no longer tries to create
/var/tmp/install when 'sysconfig create-profile'
is run
* 7079796
- verified that 'sysconfig create-profile' exits with error
when profile can't be created:
# sysconfig create-profile -o /sc.xml ; echo $?
Failed to generate SC profile.
Exiting System Configuration Tool. Log is available at:
/system/volatile/sysconfig.log
1
#
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
