Hi Drew,
lines 578-588, and 639-640. This is identical code to lines 248-256 and
293-294.
Since this is the logic to use an alternate repo, I think it might be
better to
point in functions that can be called. In the future, if further setup
is needed
to point to an alternate smf repo, it can just be added in 1 single place.
Another thought is that perhaps we can leave all those env variables set
after the
configure_smf() function, and not unset it until the whole checkpoint is
done.
Then, we won't have duplicate code either.
line 592: question: would it make sense to make the stderr_loglevel to
be "error"
so it is consistent with line 597 below?
Thanks,
--Karen
On 10/19/11 10:26 AM, Drew Fisher wrote:
Let the code reviews commence!
Could I please get a code review for
7092599 <http://monaco.us.oracle.com/detail.jsf?cr=7092599>
distro-constructor can build invalid LiveCD when svccfg fails
https://cr.opensolaris.org/action/browse/caiman/drewfish/7092599/webrev/
I tested this by building 175 on a host system running 173 (there was
an SMF schema change in 174):
<snip detail log>
2011-09-29 17:17:42,853 InstallationLogger DEBUG Executing:
['/usr/sbin/svccfg', 'list', '*desktop-cache*']
2011-09-29 17:17:43,686 InstallationLogger DEBUG
application/desktop-cache/gconf-cache
application/desktop-cache/mime-types-cache
application/desktop-cache/icon-cache
application/desktop-cache/desktop-mime-cache
application/desktop-cache/pixbuf-loaders-installer
application/desktop-cache/input-method-cache
This works because we're now correctly setting all of the proper SMF
environment variables, exactly the same way that we do when we import
all the services.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
