Hi Drew, I took at look at this, in general all looking good, but I do have some questions/comments:
- Generally I wonder if the name 'create_child_slice' doesn't convey the fact that all existing slices will be deleted well enough. I don't have any specific suggestion and "create_slice_replacing_all_others" is probably a bit verbose ;) - test_shadow_list.py Would it be worth adding a test to verify that it's the only slice created after the call. Thanks, Darren. On 24/10/2011 15:28, Drew Fisher wrote: > Good morning! > > Could I get a code review for: > > 7091425 <http://monaco.us.oracle.com/detail.jsf?cr=7091425> Partition > should have method create_child_slice() > > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7091425/webrev/ > > Beyond the new unittests, I tested both the GUI and text-installer to make > sure the new replacement works as intended. > > Thanks! > > -Drew > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
