Hi:

Could I please get a code review for


7104391 <http://monaco.us.oracle.com/detail.jsf?cr=7104391> pep8 and pylint errors in solaris_install/ict

Webrev is here:


https://cr.opensolaris.org/action/browse/caiman/md5645/7104391

The following testings had been done:

1. Run full slim_test and there is no failure:

The test results logs are here:

/net/indiana-build/export/home/ding/7104391/slim_source/7104391_test_results_3

2.  I did DC builds for LiveCD and AI isos with the new packages.  I had done 
livecd and AI install and they work fine.

3.  I ran pep8 on the affected files and warnings are gone.

4.  I ran pylint on the files and confirmed that the following errors are fixed:



1. W0611 - Unused import
2. W0612 - Unused variable
3. W0613 - Unused arguments
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to