HI Mary.

usr/src/README:

line 41 still refers to onnv-tools.

usr/src/tools/tests/README:

nit: split line 58.  It is too long.

Is a sudo needed on line 111?

Seems prudent to me to include a warning somewhere to exclude tests which would alter the system, since tests will now be running with root privileges.

Ideally there would be an automatic way of excluding those destructive tests, for example a standardized environment variable which could be checked by those tests, which would have to be set before those tests would be executed. (This may be beyond the scope of this push, however.)

    Thanks,
    Jack

On 10/31/11 03:09 PM, Mary Ding wrote:
Hi:

Can I get a code review for:

7104155 <http://monaco.us.oracle.com/detail.jsf?cr=7104155> tools/tests/README not consistent about unit tests running environment 7106969 <http://monaco.us.oracle.com/detail.jsf?cr=7106969> Need to update usr/src README to reflect s11 update1 changes

Web rev is here:

https://cr.opensolaris.org/action/browse/caiman/md5645/7104155_7106969



I had followed the README instructions and confirmed they work fine as follow:

1. Install devloper/build/onbld from http://ipkg.us.oracle.com/internal/solaris11/on/onbld

2.  Compile slim_source and there is no issue

3. Confirm the slim_tests can run successfully without any issues with sudo


If this is approved, I will send a heads up to remind people to update their onbld and Sunstudio tools to /ws/on11update-tools
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to