John,
I don't need to see another webrev for the changes made so far, but have
a question and another comment below ...
On 11/02/11 14:08, John Fischer wrote:
Ethan,
Thanks. I appreciate the review.
See below. Do you want another
webrev?
John
On 11/ 2/11 11:24 AM, Ethan Quach wrote:
Just found some nits in comments ....
aimdns_mod.py:
---------------------
449 - nit - "after the this value" ?
Changed from:
# the cache after the this value but prior to another service
to:
# the cache after this value expires but prior to another
service
test_aimdns_manual.py:
-------------------------------
88-94 - Any reason why this comment chunk can't be chucked?
Removed. Added the following comment prior to the Register() call:
# Use "dns-sd -B _OSInstall._tcp local" to monitor Addition and
# Removal of services.
Couldn't /usr/lib/installadm/aimdns.py be used here instead? But in
either case, I'm not quite getting what this comment meant to achieve?
178 - Since we're not using dns-sd in this test code to publish anymore,
does this comment need to be updated as well?
thanks,
-ethan
131 - Seems like this comment needs to be updated.
Changed to:
Use the AImDNS class to create a fake mdns service.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
