Sanjay,
I've added a couple of rudimentary tests but have avoided reproducing
all of the shadow_list tests for the new code. We currently have no
tests which test discovery (as all of that information comes from
libdiskmgt and that's hard to fake) so I've had to write the tests in
test_shadow_list.py
https://cr.opensolaris.org/action/browse/caiman/drewfish/7091282_2/webrev/
Thanks.
-Drew
On 11/8/11 10:55 AM, Sanjay Nadkarni wrote:
The fix looks good to me but are there test cases that need to be
modified for 4k block ? i.e. are there tests that suffer from a
similar issue ?
-Sanjay
On 11/8/11 9:06 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following CR:
7091282 <http://monaco.us.oracle.com/detail.jsf?cr=7091282>
Installers do not report large-sector-size disks correctly
https://cr.opensolaris.org/action/browse/caiman/drewfish/7091282/webrev/
This CR is a fix of only the display of disks in all three
installers. What was happening was the blocksize of the disk was not
being passed to the Size object. The Size objects default to a
blocksize of 512b so the 4k blocksize disks were showing up at 1/8th
of their original size.
There is still pending ON work from another team (see CR 7079565 and
a still-pending ARC case) which will address changes to the sd driver
to support full installations to these types of disks.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
