On 11/21/11 12:04 PM, Nirmal Agarwal wrote:
Hi Susan
Please find my responses inline :
On 11/21/11 09:52 AM, Sue Sohn wrote:
On 11/18/11 02:36 PM, Nirmal Agarwal wrote:
Hi Susan
Thanks for reviewing the changes. Please find the revised webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/CR7041537-2
On 11/16/11 01:04 PM, Sue Sohn wrote:
On 11/15/11 02:53 PM, Nirmal Agarwal wrote:
Hi all
Could I please get a code review for the following CR :
7041537 It will be nice to have an installadm update-profile command
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/CR7041537
Test Results :
slim test
---------
results stored at : /export/home/na210770/ai/7041537/slim_source/test.result
manual tests :
-------------------
ran "installadm update-profile " with "-f" option and profile without templates
and with
templates.
Error out if the new profile contains templates not present in the criteria of
the profile.
Let me know if I need to run some other tests.
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
create_profile.py
-----------------
309 validates the profile and report the errors if found
->
validate the profile and report errors if found
test_create_profile.py
----------------------
199 and 208 class to mock -> class for mock
487 As we discussed offline, can you add some comments here to explain what is
going on?
fixed all the nits. Please find the updated webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/CR7041537-3/webrev/
I have tested the cases suggested by you.
Test results :
Manual-tests ---
/net/indiana-build/export/home/na210770/ai/7041537/slim_source/manual_test.result
slim-test ---
/net/indiana-build/export/home/na210770/ai/7041537/slim_source/slim_test.result
I took a quick look and didn't see a test of update-profile where only the -f
option was used.
Have you tested this?
Yes I have tested the same and it works as expected. I have updated the test
result document with
the same.
Looks ok now.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
