Thanks a lot William :-).
I will change the comment as you suggest.
Regards,
Tomas D.
Dne 28.11.11 16:02, William Schumann napsal(a):
Tomas,
I think that you meant 'stuff' instead of 'staff'. 'stuff' is slang -
suggest more formal language.
Here, "which" is a relative pronoun that requires a comma, whereas
"that" is a conjunction and does not require a comma.
So, suggest changing:
# CHECK_SETUP_SCRIPT contains math staff which needs to run in "C" locale
to
# CHECK_SETUP_SCRIPT does math processing that needs to run in "C"
locale ...
Otherwise, looks fine to me.
William
On 11/28/2011 1:39 PM, Tomas Dzik wrote:
Hi all,
I would like to kindly ask you for code-review for
7112418 - installadm create-service fails with czech locale set
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7112418/
The changed python code is pep8 clean and all tests in gate passed.
I also tried to install built binaries and verified that installadm
create-service works now with czech locale set using LANG variable as
well as using LC_ALL variable.
I am setting the right environmental variables in python and not in
script itself because setting the variables in script didn't work
correctly, probably because of the bug in ksh. (The trouble here is
caused by fact that math is built-in in ksh and ksh behaves
differently if you set locales before ksh script is run compared to
situation when you set locales in script itself.)
Thanks a lot in advance.
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
