That looks fine, thanks.
Dave
On 02/01/12 10:48, Matt Keenan wrote:
Posted updated webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7130956/
containing removal of the uncessary UPGRADE text files.
will run another set of ISO's and do some test installs to ensure all is
good.
cheers
Matt
On 02/01/12 15:38, Dave Miner wrote:
On 02/01/12 10:25, Matt Keenan wrote:
On 02/01/12 15:09, Dave Miner wrote:
Matt, two questions:
- Why shouldn't we just deliver the legacy /var/sadm... path as a
symlink in one of the packages?
In system-install.mf package manifest there are three references of
note :
dir path=var/sadm group=sys
dir path=var/sadm/system group=sys
link path=var/sadm/system/logs target=../../log/install
From this you can see /var/sadm and /var/sadm/system will both be
created as directories and /var/sadm/system/logs will be created as a
symlink to /var/log/install
Are you suggesting we change the creation of the dir's to be just
symlinks as well ?
If so linked to what ?
Sorry, I misunderstood the evaluation of the bug, which indicated the
installers were creating this link. The above is what I would expect.
Dave
- Why do we still have the UPGRADE_FAILURE_PANEL.txt file? We haven't
allowed upgrades from the installer since the Dwarf Caiman days.
I'm happy to remove these as part of this bug fix if you want.
cheers
Matt
Dave
On 02/01/12 04:48, Matt Keenan wrote:
Karen,
Thanks for the review.
The first paragraph of the Evaluation was in response to this comment,
indicating that the symlink is already being created by all three
installers.
Do you still feel I need to add more ?
cheers
Matt
On 01/30/12 18:12, Karen Tung wrote:
Hi Matt,
The code changes look good to me.
I have a question about Comment entry 1 that Dave made in the bug.
The comment talks about deliver /var/sadm/system/logs as a link to
/var/install/log.
I do not see any response to that comment or the code changes
implementing that.
Can you update the bug to talk about what you are doing for Dave's
comment?
Thanks,
--Karen
On 01/30/12 09:50, Matt Keenan wrote:
Hi,
Can I get CR for following bug :
7130956 - Change default log location to /var/log/install
http://monaco.us.oracle.com/detail.jsf?cr=7130956
Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7130956/
This fix is a follow on from the recently integrated bug 7107775, and
turned out to be a lot less painful than envisioned, in fact rather
trivial.
Testing :
- Built all three ISOS ai/text/gui and test installed to ensure logs
are being installed to /var/log/install
- Ran complete set of unit tests and no regressions found.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
