Niall and Sue:
My comments are just minor nits:
1. Since you are changing usr/src/cmd/installadm/dhcp.py, can you fix
the following pylint Bad indentation errors ???
W:1486: Bad indentation. Found 12 spaces, expected 8
W:1487: Bad indentation. Found 16 spaces, expected 12
W:1489: Bad indentation. Found 16 spaces, expected 12
Thanks !!!
On 01/31/12 08:50 PM, Niall Power wrote:
Resend because I forgot the URL - duh!
Hi all,
I'm sending out this review request on behalf of Sue - please make
sure she is included in code review comments.
This is a follow on from the UEFI/GRUB2 and large disk boot review
requests that were sent out over the past month. This webrev consists
of the changes to installadm to allow it to provision and serve native
UEFI network clients and to add support for GRUB2 based images. The
backend handling of Legacy GRUB that installadm has currently
implemented is replaced by the use of pybootmgmt to manage the boot
configuration of new services/clients and modification of existing
services/clients. pybootmgmt deals with the specific boot loader
configuration details of both Legacy GRUB and GRUB2 based services.
We'd like to gather all code review comments by COB Feb. 7th please.
The webrev is at:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-installadm-uefi-1/
Thanks in advance!
Niall & Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
