Hi Sanjay,
since we talked about this one... :-)
The changes look good, I am only wondering if it may make sense
to transmute functions _get_dns_search(), _get_domain() and
_get_nameservers()
into one function, since they accomplish almost the same thing - obtain
value
of smf property of one smf naming services and they duplicate bunch of
the code.
To account for differences, new function may look like:
def _get_naming_info(svc, property_name, quote_result=False)
where
* naming_service - 'dns' or 'nis'
* property_name - 'DOMAIN_PROP', 'SERVER_PROP', 'DOMAIN_SEARCH_PROP'
* quote_result - if True, quoteresulting entries
Thank you,
Jan
On 02/11/12 04:22 AM, sanjay nadkarni wrote:
Could I get a few eyeballs for this simple fix.
https://cr.opensolaris.org/action/browse/caiman/nadkarni/dhcp/webrev/
Thanks
-Sanjay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
