I'll let Dermot handle the GUI specific ones, but you commented on one
other issue
On 2/19/12 8:56 PM, Niall Power wrote:
Hi Drew & Dermot,
Here are my comments for the GUI changes. I'll try to squeeze in time
to look at the target libraries also.
47 & 296: cache_update() It looks wrong to me for the GUI (or other
client) to be trying to manipulate libdiskmgt, which is just an
implementation detail of target_discovery. It sorta violates that
whole MVC thing :) Why can't target discovery take care of this itself
when doing iSCSI discovery?
Remember how discovery and physical.py did all that song and dance about
calling fork() so we could lay down a label and gather geometry data?
We had to do this because libdiskmgt had no external function that we
could use to force a rebuild of the cache. Instead, the library rebuilt
the cache every 60 seconds.
When we call cache_update(), it's because we want to force libdiskmgt to
find the newly mapped iSCSI LUN rather than waiting for a maximum of
62-65 seconds (60 for the cache rebuild timer + 2-5 seconds for the
cache refresh). Putting it directly in the hands of the GUI (and TI -
see disk_selection.py) lets the GUI control when it wants to rebuild the
cache AND to block while that cache rebuilds. We'll know for certain
that the LUN is mapped and libdiskmgt knows about it when the call returns.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
