Hi Tomas, Looks good to me.
Thanks, Darren. On 23/02/2012 14:50, Tomas Dzik wrote: > Hi all, > I would like to ask you for a code review for: > > 7129773 - installadm create-service outputs some error > > Webrev is here: > > https://cr.opensolaris.org/action/browse/caiman/t.dzik/7129773/ > > Testing done: > > 1) Source is pep8 clean > 2) I run test suite which is part of the gate > 3) I reproduced the reported error on sparc machine (the error appears > only on sparc and with locale using , as decimal delimiter e.g. cs_CZ) > 4) I copied fixed service.py and verified that problem disappeared. > > Note: The fix is exactly the same like fix for related bug 7112418 > > Thanks, > > Tomas D. > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
