Looks good to me Drew. Thanks,
Darren. On 03/03/2012 18:10, Drew Fisher wrote: > Good morning! > > Could I please get a quick code review for the following CR: > > 7145653 <http://monaco.us.oracle.com/detail.jsf?cr=7145653> specifying more > than one filesystem with mountpoint of "legacy" or "none" causes error > during AI > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7145653/ > > I tested this by adding new unittests and by also testing out the sample > <target> snippet from the CR in AI: > > sudo auto-install -i -m ai_default.xml > 11:01:27 Install Log: /system/volatile/install_log > 11:01:27 Using XML Manifest: ai_default.xml > 11:01:27 Starting installation. > 11:01:27 0% Preparing for Installation > 11:01:27 100% manifest-parser completed. > 11:01:27 0% Preparing for Installation > 11:01:27 1% Preparing for Installation > 11:01:27 2% Preparing for Installation > 11:01:27 3% Preparing for Installation > 11:01:40 18% target-discovery completed. > 11:01:40 === Executing Target Selection Checkpoint == > 11:01:40 Selected Disk(s) : c3t7d0 > 11:01:40 Existing zpool 'rpool' will be destroyed. > 11:01:40 58% target-selection completed. > 11:01:40 86% ai-configuration completed. > 11:01:40 99% var-shared-dataset completed. > 11:01:40 Automated Installation paused at checkpoint: target-instantiation > 11:01:40 Automated Installation succeeded. > 11:01:40 You may wish to reboot the system at this time. > > > (Ignore the message about 'rpool' being destroyed) > > As you can see, everything works now. > > Thanks! > > -Drew > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
