Hi Karen,
Looks good now.
Sue
On 03/ 7/12 11:42 AM, Karen Tung wrote:
Hi Sue, Mary and Drew,
Thank you for the code review. I updated the code to modernize the
logger calls and remove the backslashes as suggested. I built an AI image
to make sure the changes did not cause any problems. I also run all the
unit tests as suggested by Mary, and found no regression.
The updated webrev is at:
https://cr.opensolaris.org/action/browse/caiman/ktung/7073683-2/webrev/
Thanks,
--Karen
On 03/07/12 07:30, Sue Sohn wrote:
On 03/ 7/12 05:49 AM, Drew Fisher wrote:
Karen,
My only comment would be to say that we should modernize the logger calls to
use printf-style
replacements rather than string concatenations.
242 self.logger.debug("skipping root dir " + root + \
243 " due to exclude list")
Becomes:
242 self.logger.debug("skipping root dir %s "
243 "due to exclude list", root)
To keep things more in sync with the behavior of the rest of the gate.
-Drew
Also, you don't need the backslash's in the logger calls due to implied line
continuation inside
of parens.
Sue
On 3/7/12 12:30 AM, Karen Tung wrote:
Hi everyone,
Please review my changes for fixing the following bug:
7073683 sparc install will fail with Fast Data Access MMU Miss if boot_archive
is corrupted during
DC build
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/7073683/webrev/
In addition to fixing the actual problem, I also improved the debug log
messages so if we ever run
into this type of problem in the future, it will be easy to identify where we
do not skip the files
and directories as we should.
Testing:
On the machine that consistently produces bad images, I created 20 SPARC AI
images,
and 10 text installer sparc images. I observed the detail logs from each of the
runs to
make sure that the directories and files we expect to skip fiocompress are
truly skipped.
Then, I randomly selected 10 SPARC AI images to make sure it can boot up fully
and install
can start. I also booted up all 10 text installers to make sure they can all
boot up correctly.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
