Happy Friday,
Can I get a code review for the following bug:
CR: http://monaco.sfbay/detail.jsf?cr=7147174
There is an additional change that isn't noted in the webrev. I moved
line 194 in target_selection.py left by one tab. The function,
__pretty_print_disk, if called with a list of disks would only create a
string with the first disk in the list. The return statement needed to
be moved out of the loop.
Webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7147174/
Testing:
pep8 clean
target selection unit tests have been run
new unit tests added
Full installs run on the default manifest and 2 representative manifests
autoinstall -i -m run on a set of manifests developed to test the changes
Note: Some have been added to the unit tests and some forwarded to QE
to include in a new, more easily run AI test suite.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
