Sorry. I thought that I had done a respond to all. -------- Original Message -------- Subject: Re: [caiman-discuss] Code Review for 7153092 Date: Mon, 12 Mar 2012 12:43:30 -0600 From: Harold Shaw <[email protected]> Reply-To: [email protected] To: Sue Sohn <[email protected]>
Hi Sue, The change looks good. It's nice that you could just tuck the call to validate_service_name under the existing comment, "validate service name". :-) Harold On 03/12/12 12:09, Sue Sohn wrote:
Can I get a code review of the changes for: 7153092 appending slash to servicename when deleting an aliased service deletes service, but not alias Webrev: https://cr.opensolaris.org/action/browse/caiman/sohn/7153092/webrev.7153092 Testing: Verified that delete-service rejects invalid service names, but continues to accept valid ones. Added new unit test for delete_service. Thanks, Sue _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
