On 03/14/12 12:13 AM, Sreedhar Chalamalasetti wrote:
Hi
Could you please review the following CR fixes
7153268 - aimanifest get includes trailing space
7037125 - installadm add-manifest usage/error message is not clear
Webrev:
https://cr.opensolaris.org/action/browse/caiman/sc157166/CR_7153268_7037125/webrev
<https://cr.opensolaris.org/action/browse/caiman/sc157166/CR_7153268_7037125>
Testing:
1. aimanifest:
- aimanifest get ... returning correct value without space at the end of value.
- aimanifest get -r returning "value path".
2. installadm add-manifest/create-manifest/update-manifest: Displays error
messages as follows.
- installadm: error: Missing required option -n <service_name>.
- installadm: error: Missing required option -f <manifest_file>.
3. pep8 clean.
4. slim_test OK. Results:
/net/indiana-build/export/home/sc157166/bugs/7153268/slim_source/slim_tests_output.txt
Thanks
Sreedhar
Hi Sreedhar,
publish_manifest.py:
122 and 127 Please line up under "Missing..." from line above
127 Rather than <manifest_file>, use <manifest/script file> so that the option name in the error msg
matches what is in the usage.
aimanifest.py
278 No need for parens around value
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
