Looks good. Thanks.
Harold
On 03/15/12 02:49 AM, Nirmal Agarwal wrote:
Hi Harold
Thanks for the review.
I changed the fix to display the value of AIM_LOGFILE in the error
message.
Please find the updated webrev.
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7142286/webrev/
Regards
Nirmal
On 03/15/12 03:27, Harold Shaw wrote:
Hi Nirmal,
It looks good. The only question that I have is whether it would be
useful to include the value of AIM_LOGFILE as part of the error output?
AIM_LOGFILE I/O Error(21) : Is a directory: '/somedir'
Harold
On 03/14/12 02:21 AM, Nirmal Agarwal wrote:
Hi all
Can I please get a code review for CR 7142286.
7142286 aimanifest generates stack trace if environemnt variables are
set to directory instead of a file
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7142286/webrev/
Source is pep8 clean.
Tests :
--> Set the AIM_LOGFILE=/somedir and run aimanifest
root@vbox:~# aimanifest
AIM_LOGFILE I/O Error(21) : Is a directory
--> Set the AIM_LOGFILE=/etc and run as non root user.
vbox@vbox:~$ aimanifest
AIM_LOGFILE I/O Error(13) : Permission denied
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
