Hi Jack,
Please see my comments inline. I removed all items where I have no
further comments.
On 03/16/12 03:06 PM, Jack Schwartz wrote:
usr/src/cmd/system-config/profile/support_info.py:
- The _fork_proc() function:
My understanding of this function is that you want to be able
to kill the process after the specified timeout. If that's the case,
why is it necessary to have all the logic to do non-blocking read
of the stdout and stderr? You are not processing any of the information
you read from stdout and stderr anyway
While it is true that I am not processing info while I am looping, the
stdout "pipe" can fill up depending on the output of ocmadm and
asradm. (Some of the properties are large, and together could overrun
the pipe depending on the pipe size.) By reading, I continuously
empty the pipe so that it won't fill up. Deadlock will occur if the
pipe fills up and more the subprocess tries to write more.
Did you take a look at the bufsize argument for Popen? I think your
concern can be addressed
by setting bufsize=-1, so, all the output is fully buffered.
- lines 367-368: can this be:
proxy_hostname += ":" + self.proxy_port
I thought using + for strings was discouraged for performance reasons,
and join was to be used instead.
I do not know about the performance difference between using "+" or
using "join". I don't remember seeing
too much code that uses join for string concatenation. That's why I
thought it looks kinda odd.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
