LGTM.
+1 point for using a context manager :)
-Drew
On 3/19/12 12:15 PM, Nirmal Agarwal wrote:
Hi all
Can I please get a code review for CR 7088824.
7088824 installadm gets Unhandled error when the output is piped to head
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7088824/webrev/
Background :
When "head" process stops reading the output from the "installadm"
command, it generates SIGPIPE signal which python converts into IOError.
Tests :
bash-4.1$ installadm list -p|head
Service Name Profile
------------ -------
default-i386 S11U1-11-ai-profile-amina.xml
S11U1-11-ai-profile-badile.xml
S11U1-11-ai-profile-bremy.xml
S11U1-11-ai-profile-chomutov.xml
S11U1-11-ai-profile-divizna.xml
S11U1-11-ai-profile-erebos.xml
S11U1-11-ai-profile-gemini.xml
bash-4.1$ installadm list -m|head
Service/Manifest Name Status Criteria
--------------------- ------ --------
default-i386
S11U1-11-manifest-amina mac = 00:0A:E4:26:DF:0B
S11U1-11-manifest-badile mac = 00:0A:5E:43:9D:8D
S11U1-11-manifest-bremy mac = 00:0E:0C:08:1A:40
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
