Niall:
A couple more nits:
1.
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/usr/src/cmd/distro_const/checkpoints/pre_pkg_img_mod.py.html
line #42, should remove the used import Popen
2.
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/usr/src/cmd/gui-install/src/disk_screen.py.html
line#456 and 457:
logging.debug("Selected disk [%s] is too small for " \
"installation" % disk.ctd)
I think it should be:
logging.debug("Selected disk [%s] is too small for " \
"installation" disk.ctd)
3.
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/usr/src/lib/install_target/logical.py.html
line#44 and #45, the following used imports should be deleted:
from solaris_install.target.libbe.const import ZFS_FS_NAMES, \
ZFS_SHARED_FS_NAMES
On 03/19/12 18:33, Mary Ding wrote:
Niall:
My comments are nits. pylint had been complaining about some of these
warnings/errors and it will be nice if those can be fixed:
1.
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/usr/src/cmd/installadm/create_service.py.html
line #42 should be removed as pkg.client.history is already imported
from the following line #39
import osol_install.auto_install.installadm_common as com
2.
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/usr/src/cmd/installadm/service_config.py.html
line #322:
logging.log(com.XDEBUG, "aliases=%s" % aliases)
It probably should be:
logging.log(com.XDEBUG, "aliases=%s" aliases)
On 03/19/12 15:37, Niall Power wrote:
Hi,
In addition to distro constructor, I aim to integrate the installadm
changes into build 13, before the final UEFI/GRUB2 feature push in
build 14.
This will ease the transition for admins and reduce flag day
severity, since an AI server upgraded to build 13 will be able to
provision build 14 (GRUB2 based) images and service UEFI clients.
So, this webrev is a strickt subset of the overall UEFI project
webrev and has already been code reviewed. The main purpose of this
request is to ensure that the right pieces have been taken from the
main webrev and that nothing is missing to satisfy installadm.
I have built and sanity tested this subset webrev to ensure that it:
- can import, provision a legacy GRUB based AI ISO image, and that
the client can boot from it.
- can import, provision a GRUB2/UEFI based image, that it creates
bios and uefi dhcp entries, and that the client can boot from it.
installadm specific webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-installadm-uefi-2012-03-19/
original full project webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-slim-uefi-2012-03-19/
Thanks!
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
