On Wed Mar 21 11:05:53 2012, Niall Power wrote: > Hi Dermot, > > Thanks for reviewing. > > On 21/03/2012 22:04, Dermot McCluskey wrote: >> Hi Niall, >> >> The following files do >> "from bootmgmt.bootinfo import SystemFirmware": >> ./cmd/auto-install/checkpoints/target_selection.py >> ./cmd/text-install/disk_selection.py >> but do not get the bypass. So, I assume the version >> of bootmgmt is not that important for them? > > Yes, because these files belong to AI and Text Install clients respectively > so they will be part of a pre-assembled image and not something you > would expect to be installed onto a physical system.
Actually that is not true - AI certainly is installed on a physical system since it is used to install zones. Darren. > > Thanks! > > Niall > >> >> Otherwise, looks fine. >> >> >> - Dermot >> >> >> >> On 03/21/12 04:30, Niall Power wrote: >>> Hi, >>> >>> I'd really appreciate a review for this. >>> The issue is that we plan to deliver distro-constructor and >>> installadm with UEFI/GRUB2 capability in build 13. >>> To ensure this, a minimum version of pybootmgmt >>> (system/library/boot-management) version 13 is required. >>> So we need to stipulate this dependency manually to prevent >>> installation of these packages on pre build 13 >>> ON base systems, as they are incompatible with boot-management < 13. >>> >>> Because pkgdend(1) auto generates dependencies and pulls in >>> dependencies from python imports it is necessary >>> to suppress the dependency generation for specific python files that >>> import bootmgmt directly. >>> >>> I have consulted with the pkg engineers on pkg-discuss and this the >>> recommended solution by them. >>> >>> I have commented all the changes I made, but because pkgfmt has >>> reformatted other stuff that I didn't change >>> you will see some debris from moving stuff around. >>> >>> My changes are restricted to the addition of lines of type: >>> +# Add manual boot-management version 13 dependency for UEFI/GRUB2 >>> compat. >>> +depend type=require \ >>> + fmri=pkg:/system/library/[email protected],5.11-0.175.1.0.0.13 >>> >>> >>> +# Add manual boot-management version 13 dependency for UEFI/GRUB2 >>> compat. >>> +# Make sure to remove the pkg.depend.bypass-genererate actions if >>> removing. >>> +depend type=require \ >>> + fmri=pkg:/system/library/[email protected],5.11-0.175.1.0.0.13 >>> >>> >>> +# Add bypass generate to allow manual boot-management version 13 >>> dependency >>> file \ >>> >>> path=usr/lib/python2.6/vendor-packages/osol_install/auto_install/set_service.py >>> \ >>> - group=sys >>> + group=sys \ >>> + >>> pkg.depend.bypass-generate=^usr/lib/python2.6/vendor-packages/bootmgmt/.*$ >>> >>> >>> Note that distro-constructor does not currently pull in >>> boot-management as a dependency >>> so it is merely sufficient to specify the dependency, without needing >>> to suppress anything >>> >>> install/installadm and system/library/install in contrast, do need to >>> suppress the auto dependency generation >>> >>> Webrev: >>> http://jurassic.us.oracle.com/~npower/webrevs/webrev-explicit-boot-management13-dep/ >>> >>> >>> Thanks! >>> Niall >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
