Nirmal,
Sorry your fine. Didn't realize we were outputting a set. Your
changes are fine.
- Kristina
On 3/26/2012 1:34 PM, kristina tripp wrote:
Nirmal,
In service_config.py
295 raise ServiceCfgError(cw(_('\nError: installation service
key '
296 'properties missing for
service %(name)s:'
297 ' %(properties)s\n') %
{'name': svcname, \
298 'properties': ',
'.join(missing)}))
299
300
This message won't localize properly due to the ', '
It doesn't look like it's even necessary for it to be there due to the
preceding ":"
Otherwise everything else is OK.
- Kristina
On 3/20/2012 3:59 AM, Nirmal Agarwal wrote:
Hi all
Can I please get a code review for CR 7154017.
7154017 some of installadm message strings use multiple unnamed
parameters
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7154017/webrev/
Slim-test : pass
Source is pep8 clean.
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
