Drew:
My comments are nits:
1. usr/src/lib/install_target/discovery.py
Can you remove the following unused import according to pylint audit for
line 48:
from solaris_install.target.libdiskmgt.attributes import DMMediaAttr
On 03/29/12 08:08 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following CR:
7157666 <http://monaco.us.oracle.com/detail.jsf?cr=7157666> There was
the I/O error while ran discovery.py on i86pc arch AI Client
https://cr.opensolaris.org/action/browse/caiman/drewfish/7157666/webrev/
Testing: I've run target discovery in batches of 10 iterations trying
to get the error to reproduce and have been unable to do so. Also,
all of the target unittests pass and there are no new pep8 issues.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
