Good addition to check the tuple. While I am not a package expert, the bypass is just like every other bypass in the file.
So: +1 -Dave On Mar 29, 2012, at 3:41 PM, Drew Fisher wrote: > Good afternoon! > > I need to get a code review request for the following two bugs: > > 7157666 There was the I/O error while ran discovery.py on i86pc arch AI > Client > 7157850 after UEFI Phase 2 integration, slim_source gate fails to build due > to duplicate dependencies > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7157666_2/webrev/ > > The first CR was reviewed this morning by Dave Marker and Jesse but I found > another issue in the fix so I wanted to run this past the group again. > > I added this: > > 749 # skip USB floppy controllers > 750 if drive.controllers and > drive.controllers[0].floppy_controller: > 751 continue > > We want to make sure the drive has a controller tuple before we try to access > element 0. > > > The second CR is a remnant of the Phase 1 UEFI push. When we locked > system/library/install against a specific version of bootmgmt, we missed one > file (diskmgt.py). > > I've retested everything and all target unittests come back clean. pep8 and > pylint were also run and I fixed a couple of small nits. > > Thanks! > > -Drew > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
