Hi,
I have a few comments:
- General comment: Please make sure all the lines obey the 80 characters
per line limit.
I noticed a few files in the "20120326-pheimlic-installer-IPS0-src" list
of files that have lines
longer than 80 characters.
usr/src/cmd/js2ai/modules/conv_sysidcfg.py:
line 1319: Question: is it really true that this path for S10 is also
changing?
Just want to make sure this is an intended change, and not a change because
of global search and replace?
usr/src/Makefile.master:
line 104: Adding the use of /usr/gnu/bin/grep makes the buiding of the
slim_source gate dependent on the pkg:/text/gnu-grep package. Do you know
whether this package is installed by default? If not, please update
the usr/src/README to document that the gnu-grep package is required to
build slim_source.
usr/src/cmd/system-config/Makefile:
line 59: Why is profile/user_info.py listed here, while other files in
the profile directory is not? I think it would be useful to have a comment
here to explain.
Thanks,
--Karen
On 04/02/12 11:41, Jack Schwartz wrote:
Hi everyone.
I am posting this code review for Takeshi Asano and Pavel Heimlich of
the Globalization Team since they were having issues posting directly
to cr.opensolaris.org. They are making changes to our gate to create
po files (libraries of messages to localize) and deliver them in their
own package. The webrev is split into two: one for Makefiles, the
other for source files.
They are targeting build 14, so please review by Wednesday 4/4 COB.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7117291_1
Be sure to include their email addresses on any replies.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
