John,
service_config.py - 69 - I don't see AI_HTTPD_CONF referenced elsewhere
in this file. Is this file being imported from another file, and that
variable used? If so, I couldn't find it.
setup-image.sh - 38 - Same here for AI_HTTPD_CONF
setup-service.sh - 41 - Same here for AI_WS_CONF
-ethan
On 03/30/12 17:38, John Fischer wrote:
Ethan, Harold, and . al.,
I have modified the webrev to match the discussion both sent to
caiman-discuss
and off-alias. There are now no files being installed into
/var/installadm but instead
only /var/ai.
The following webrevs are available:
A complete webrev
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-3
Differential webrev between original and current
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-3-dif
Differential webrev between review 2 and current
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-3-2-d
Same testing has been done.
Thanks,
John
On 03/30/12 11:35 AM, Ethan Quach wrote:
John,
A few nits ...
Makefile.cmd
----------------
46 - Can you change the value to be $(ROOTVARINSTADM)/service-conf-templ
47 - This one is going to be a pain in the butt but, could you rename
this to ROOTVARINSTADMAIWEBTMPL to be consistent?
ai-httpd.conf
-----------------
The block comment references the wrong path in a few places:
ai-webserver-templates -> ai-webserver-templ
svc-install-server
----------------------
120 - instead of hard coding these paths, why not use the variables:
"Creating $AI_HTTPD_CONF as a symbolic link."
-ethan
On 03/29/12 15:19, John Fischer wrote:
All,
Here is the second round for this code review.
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-2
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy-2-dif
**
**Note: shows the addition of the libefi to the Targetsdirs file
from Niall's push
Ethan and I discussed the current solution. We decided to separate
the static and dynamic content from each other. So now there are
template directories for the services and the webserver. These get
copied or symlinked from the /var/installadm directory structure to
the /var/ai directory structure.
I ran the same tests.... Still pep8 and pylint clean. I setup a new
service and additionally tested to ensure that an existing service
still worked. slim_test and regression tests were fine with nothing
new.
Thanks,
John
On 03/26/12 02:56 PM, John Fischer wrote:
All,
Can I get a review of the fix for:
http://monaco.us.oracle.com/detail.jsf?cr=7130039
7130039 configuration files copied with each new service
The webrev can be found at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7130039-config-file-copy/
The fix is to move the configuration files from /var/installadm to
/var/ai.
This involves changing more files than one might think as the build
environment, the installed tools and installation locations needed to
be modified.
The effected python file is pylint unchanged and pep8 clean. I have
ran slim_test and regression tests with copies located at:
http://xserver.us.oracle.com/~jfischer/slim_test-results.txt
http://xserver.us.oracle.com/~jfischer/regression-results.txt
I have also setup a new service and built an AI image. All tests
perform
as expected with no new regression reported from my changes.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
