Takeshi Asano said the following on 04/ 3/12 07:44 AM:
Hi Mary,
Thanks for the comments.
On 2012年04月03日 06:11, Mary Ding wrote:
Jack and Pavel:
Please make sure these are pep8 and pylint clean.
I tried pep8 in the way described in usr/src/README, i.e.:
/usr/bin/pep8 --ignore=E261,W291,W293 --count -r --show-source usr
and got many E501 (line too long) and other types of errors/warnings.
- among files got E501 (line too long), these files are which touched
by the webrev so Pavel please check them and fold if lines we touched
are exceeding 80 chars.
usr/src/cmd/gui-install/src/__init__.py
usr/src/cmd/installadm/installadm_common.py
usr/src/cmd/js2ai/modules/common.py
usr/src/cmd/system-config/__init__.py
usr/src/cmd/text-install/__init__.py
usr/src/lib/install_manifest_input/__init__.py
Other files are not be touched by the webrev.
- none of files got other types of errors/warnings are touched by the
webrev.
Regarding pylint, is there any configuration file for other standard
way for slim gate?
Since changes in .py files by the webrev are message domain name updates
and fold of lines, value to apply pylint is to detect unintended misedit.
But simply applying pylint to each of the .py files touched looks to
generate other errors/warnings.
I will also like to know what kind of testing had been done with these
changes:
1. Have install_unit_test had been run ???
No,although this time's change should not affect functionality of
install components, running the suite will be good to detect
regression. I'll try that.
If you have additional information to usr/src/tools/tests/REDAME,
please let me know.
I ran
./slim_test -c tests.nose
and got the same failures as without the changeset (35 failures in
BootmgmtPropertyWriteError, NetBootConfig; perhaps env. issue?)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
