Hi John
On 04/03/12 20:35, John Fischer wrote:
Nirmal,
No. I do not need to see another webrev.
Did you perform regression testing?
I just ran slim-test. But I haven't confirmed the messages which I have
changed. I will plan to test the messages.
Thanks
Nirmal
Thanks,
John
On 04/ 3/12 07:40 AM, Nirmal Agarwal wrote:
Hi John
Thanks for the review . I will fix it.
Do you need another webrev ?
Thanks
Nirmal
On 04/03/12 20:09, John Fischer wrote:
Nirmal,
usr/src/cmd/installadm/installadm-convert.py:
The %(property)s does not match the dictionary entry:
701 sys.stderr.write(cw(_('%(cmd)s: warning: Unable to delete the '
702 'property group: %(property)s' %
703 {'cmd': cmd, 'proprty': pg_name})))
Thanks,
John
On 04/ 3/12 06:51 AM, Nirmal Agarwal wrote:
Hi all
Can I please get a code review for CR 7158566.
7158566 some of installadm message strings use multiple unnamed
parameters - part 2
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7158566/webrev/
Pep8 is clean and pylintrc output is unchanged.
Slim-test - Pass
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
