On 04/ 6/12 10:08 AM, Takeshi Asano wrote:
Hi Sue
Thank you for the comments.
On 2012年04月07日 00:44, Sue Sohn wrote:
Hi Takeshi-san and Pavel,
I have a couple of questions/comments:
I noticed that gettext.install() uses "solaris_install_installadm" for files in
the installadm
directory, but uses "solaris_install_aiwebserver" for files in the ai-webserver
directory. Is this
the intended organization of the po files? I am asking because there are some
files in
ai-webserver, such as create_profile.py, publish_manifest.py, set_criteria.py
(and others) which
are part of the installadm command so I was wondering if those should be using
"solaris_install_installadm" instead.
We've split message domains at boundary of first level directories
under usr/src/{cmd,lib}/, because it enables simple description
in Makefiles. Even if components in two of such directories
are installed and used together, having their messages in
separate .po (.mo when compiled & installed) files has no problem.
If all files in usr/src/cmd/ai-webserver are actually part of
installadm (they seems to be in install/installadm package),
merging ai-webserver to solaris_install_installadm domain looks possible.
But it's a bit less simple in Makefile because ai-webserver is not
a subdirectory of installadm.
Should there be Makefile changes for usr/src/cmd/ai-webserver/Makefile?
Sorry I didn't include ai-webserver in description of the CR (7117291)
because I thought ai-webserver might be a service process
unlike installadm which admin runs manually.
But if it's misunderstanding and actually ai-webserver components are
part of installadm and prints messages to user (admin)'s terminal,
actually enabling generation of solaris_install_aiwebserver.po in Makefile
will be done.
If doing update, can we file another CR for this and to address
it separately from current case?
I guess I have a slight preference for doing it all as one set of changes to keep everything
together, unless there's a pressing need to get what you have so far into a certain build.
Sue
And in install-message-files.mf, should there be a
solaris_install_aiwebserver.po entry added to
73-82?
When Makefile is modified to generate solaris_install_aiwebserver.po,
yes adding its line to the .mf will also be done.
Thanks,
Takeshi
Sue
On 04/ 4/12 06:37 PM, Jack Schwartz wrote:
Hi everyone.
Here's another refreshed webrev. Version 3.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7117291_3/webrev/
Thanks,
Jack
On 04/ 3/12 11:26 AM, Jack Schwartz wrote:
Hi everyone.
Here's a refreshed webrev posted for Takeshi-san and Pavel, which address the
issues raised (pep8
warnings, README, cmd/js2ai/modules/conv_sysidcfg.py,
cmd/system-config/Makefile).
https://cr.opensolaris.org/action/browse/caiman/schwartz/7117291_2/webrev/
Thanks,
Jack
P.S. Note that Takeshi-san and Pavel are on the caiman-discuss alias.
On 04/02/12 11:41, Jack Schwartz wrote:
Hi everyone.
I am posting this code review for Takeshi Asano and Pavel Heimlich of the
Globalization Team
since they were having issues posting directly to cr.opensolaris.org. They are
making changes to
our gate to create po files (libraries of messages to localize) and deliver
them in their own
package. The webrev is split into two: one for Makefiles, the other for source
files.
They are targeting build 14, so please review by Wednesday 4/4 COB.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7117291_1
Be sure to include their email addresses on any replies.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
