Darren:

Thanks for the review. I make a typo of the bugid but the bugtraq link and code review had the correct bugid 7161980.



On 04/17/12 02:17 AM, Darren Kenny wrote:
Hi Mary,

Looks good to me :)

BTW, I found the URL below to be wrong for the CR, but got the right one in
the end ;) (8 and 9 were reversed in the destination of the link text)

    https://cr.opensolaris.org/action/browse/caiman/md5645/7161980

Thanks,

Darren.


On 17/04/2012 03:16, Mary Ding wrote:
Hi:

Can I get a quick review for the following simple fix to update
usr/src/tools/env/developer.sh:


7161890<http://monaco.us.oracle.com/detail.jsf?cr=7161980>  Should remove
the obselete -d from the usr/src/tools/env/developer.sh

The webrev is here:

https://cr.opensolaris.org/action/browse/caiman/md5645/7161980
<https://cr.opensolaris.org/action/browse/caiman/md5645/7161890>

The -d flag of nightly had been obseleted and it should be removed.

Testing is done this way:

1.  Compile with the new developer.sh on both sparc and x86 and confirm it
compiles. All known warnings in the nightly_log are known issues.

x86 log:

/net/tcu27.01.us.oracle.com//export/home/ding/7161980/slim_source/log/log.2012-04-16.17:00

sparc log:

/net/ib-sparc.us.oracle.com//export/home/ding/7161980/slim_source/log/log.2012-04-16.17:23

2.  I ran install_unit_tests and there is no failure for x86:

/net/tcu27.01.us.oracle.com//export/home/ding/7161980/slim_source/test_result

3. I ran install_unit_tests for sparc and all failures are known failures.

/net/ib-sparc.us.oracle.com//export/home/ding/7161980/slim_source/test_result


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to