Thanks Ethan
On 04/20/12 18:31, Ethan Quach wrote:
Matt,
Thanks for making the changes. Looks fine to me.
-ethan
On 04/20/12 08:28, Matt Keenan wrote:
Ethan,
Thanks for the review, better late than never :-)
All changes made and new webrev available :
https://cr.opensolaris.org/action/browse/caiman/mattman/7086449/
Generate ISO's for all install media, tested AI and TI, GUI a slight
issue because of B14 xserver bug, trying the libpciaccess,so.0
workaround now.
All unit tests pass without regressions.
Other Comments below :
On 04/19/12 18:23, Ethan Quach wrote:
Matt,
Sorry for the late reply on this, but I just had a naming nit which
will unfortunately have some impact on the code. In general, since
the mountpoint has actually turned out to be var/share, can we
update all instances of varshared -> varshare throughout?
Rename the file varshared.py -> varshare.py
Done
Lines 42, 53 -- rename the classes accordingly. (Which will impact
whereever else in our code that they are used and Makefiles, pkg
manifest, etc.)
Done, this impacts, TI, GUI and AI code, and packaging, All changes
now made, any reference to varshared in entire caiman gate is now
changed to varshare.
Can you also update the bug synopsis as well.
Done
cheers
Matt
thanks,
-ethan
On 04/18/12 06:35, Matt Keenan wrote:
Hi,
Can I get a a pair of eyes over the following code changes :
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7086449/
Bug:
http://monaco.us.oracle.com/detail.jsf?cr=7086449
s11u1_b12 saw the introduction of the creation of a VARSHARE
dataset on first boot by the SMF service script fs-minimal.
This CR is just ensuring we create this dataset during
installation, not only saving fs-minimal from having to do it, but
at the same time safeguarding against a user specifying a
conflicting VARSHARE in their manifest.
Test install ensuring VARSHARE was actually created at install time
before rebooting, and ensured initial boot succeeds successfully.
Ran full set of unit tests to ensure no regressions.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
