Thanks, Karen!
-Drew
On 4/23/12 5:21 PM, Karen Tung wrote:
Looks good to me.
--Karen
On 04/23/12 16:08, Drew Fisher wrote:
Good afternoon!
Could I get a fast code review for:
7116879 <http://monaco.us.oracle.com/detail.jsf?cr=7116879> TI can't
create solaris logical partition if extended partition size is equal
to available size
It's a small fix, so I'll just include the diffs here:
diff -r ca4e7dcd5f81 -r 927e0213e6f8
usr/src/cmd/text-install/ti_target_utils.py
--- a/usr/src/cmd/text-install/ti_target_utils.py Mon Apr 23
12:13:14 2012 +0100
+++ b/usr/src/cmd/text-install/ti_target_utils.py Mon Apr 23
17:10:40 2012 -0600
@@ -1253,7 +1253,11 @@
# of the specified type in that gap. We do not want to
# use the start sector and size value in the empty
objects
# because those are fake values.
- existing_gaps = self.parent.doc_obj.get_gaps()
+ if self.is_logical():
+ existing_gaps = \
+ self.parent.doc_obj.get_logical_partition_gaps()
+ else:
+ existing_gaps = self.parent.doc_obj.get_gaps()
if not existing_gaps:
# There's no free space anymore, do not do anything
What's happening is TI isn't looking at the proper gap for logical
partitions. If you have a disk which is 100 sectors in size with a
single extended partition which is also 100 sectors in size, the old
code would call Disk.get_gaps() and return a gap of 0 sectors.
Logical partitions have to fit inside extended partitions, and NOT
the parent disk. The fix here is to call the proper get_gaps()
method based on Partition type.
I've tested this with a VMWare guest in which I used fdisk to lay out
one single extended partition before running TI. Once to the
partition edit screen, I created a new logical partition with a type
of "Solaris2" and installed Solaris. Everything comes up just fine.
My disk has two fdisk partitions: 1 extended and 1 logical with
type 191.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
