Darren,
Mostly looks good.
software.dtd:
56: "specified in is to be rejected"
should this be : "specified is to be rejected"
ips.py:
68: LICENSE_* definitions defined twice
test/test_info.py
368: tr_node.contents defined twice
ai_manifest.4:
Lots of changes in here not related to what you are doing, not sure how
they made it into the diffs.
cheers
Matt
On 04/23/12 18:59, Darren Kenny wrote:
Hi,
Could I possibly get a code review for the following RFE:
7145997 support for avoid lists and reject during install action
should be added.
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7145997/webrev/
The primary changes are:
- The addition of the 'avoid' and 'unavoid' actions to the DTD.
These are begin added, replacing the 'noinstall' action, in the DTD.
It was felt that it was safe to remove the 'noinstall' action since it
is currently not in use anywhere.
These new actions provide the same functionality that currently exists
in IPS, at install time.
- The addition of a new '<reject>' tag in as a child of'<software_data>'
This new tag will allow the the user to perform the equivalent of the
'pkg install --reject' command.
Because of the way these are being added to the DTD, it was felt that it
was unnecessary to increment the DTD version.
Testing done:
- I built my ISOs using the modified IPS code with DC
- I performed AI installs with and without any avoid/unavoid/reject use.
- I also ran the PyUnit tests in the transfer module with no failures,
after adding some additional tests.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
