Looks good to me. On Apr 24, 2012, at 3:41 PM, Drew Fisher wrote:
> Good afternoon! > > Could I get a code review for another simple textui bug? > > 7114515 unable to change size for any solaris logical partition > > > Again, the changes are fairly simple so I'll just inline them: > > diff -r 15ba29ecb4ed -r 3f76370fa802 > usr/src/cmd/text-install/ti_target_utils.py > --- a/usr/src/cmd/text-install/ti_target_utils.py Tue Apr 24 11:31:32 > 2012 -0600 > +++ b/usr/src/cmd/text-install/ti_target_utils.py Tue Apr 24 13:31:24 > 2012 -0600 > @@ -1165,8 +1165,13 @@ > '''Returns True if it is possible to edit this partition's size''' > > if self.ui_type == UI_TYPE_IN_USE: > + # for logical partitions, only allow the user to change the size > of > + # Solaris2 partitions > if int(self.doc_obj.name) > MAX_PRIMARY_PARTS: > - return False > + if self.doc_obj.part_type == UIPartition.SOLARIS: > + return True > + else: > + return False > > if self.doc_obj.part_type in UIPartition.EDITABLE_PART_TYPES: > return True > > > The current code removes the ability to edit the size of all logical > partitions, regardless of partition ID. The change checks for a 'Solaris2' > partition ID and, if found, allows the size field to be editable. > > I've tested this inside a VMWare guest. I start with a 20GB disk, which had > a single 20GB Extended partition and 1 10GB Logical Solaris2 partition. > Inside TI, I changed the size of the logical partition to 15GB. I got almost > all the way through testing, but ran into CR 7164013. I verified in the log > file that the size of the logical partition was changed from 10GB to 15GB. I > also verified from inside the miniroot that the size of the logical partition > was 15GB (+/- rounding). > > Thanks! > > -Drew > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
