On 05/ 1/12 08:40 AM, Drew Fisher wrote:
Jack,
I missed something in your review. I have to use dc.DC_LOGGER rather
than self.logger because I'm testing the failure of a checkpoint
registered with the engine. The engine swallows all exceptions (like
ParsingError). DC walks the error service and logs all the failures
to the .info handler before finally raising RuntimeError. Those logs
are written to DC_LOGGER. Without setting it to a logging object, I
get something like this:
File
"/tank/code/cr_7163019/proto/root_i386-nd/usr/lib/python2.6/vendor-packages/solaris_install/distro_const/__init__.py",
line 261, in execute_checkpoint
DC_LOGGER.info("'%s' checkpoint failed" % failed_cp)
AttributeError: 'NoneType' object has no attribute 'info'
OK. So DC_LOGGER, while different than the rest of the file, is needed.
... and I saw your other email about moving logger setup into setUp.
Thanks Drew,
Jack
-Drew
On 5/1/12 9:23 AM, Jack Schwartz wrote:
Hi Drew.
In test_distro_const.py, there is this:
355 dc.DC_LOGGER = logging.getLogger(INSTALL_LOGGER_NAME)
In other tests of this module, the logger is set up in setUp(), and
is set in self.logger, not dc.DC_LOGGER. Shouldn't this line be
consistent with other tests?
The rest LGTM.
Thanks,
Jack
On 05/ 1/12 06:13 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review for the following bug:
7163019 <http://monaco.us.oracle.com/detail.jsf?cr=7163019> distro
name shouldn't be allowed to be blank
https://cr.opensolaris.org/action/browse/caiman/drewfish/7163019/webrev/
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
