Hi Jan,
Everything looks good to me now.
Thanks,
--Karen
On 05/03/12 01:31, Jan Damborsky wrote:
Ginnie, Karen,
thank you very much for review.
Yeah, you are right. I accepted Drew's comment,
but didn't generate updated webrev. Sorry about that.
I have created one - diffs can be looked at:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7162079-4-diff/webrev-4-diff/
And full is available at:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7162079-4/webrev-4/
Thanks again,
Jan
On 05/ 2/12 06:10 PM, Karen Tung wrote:
Hi Jan,
The changes looks good to me.
I have the same question as Ginnie about your plan on
making save_list a required argument.
Thanks,
--Karen
On 05/ 2/12 08:54 AM, Virginia Wray wrote:
Hi Jan --
Thanks...this looks good.
One comment. You and Drew discussed making save_list a required
argument to the save_files_directories function, but the webrev you
sent doesn't reflect that.
thanks,
ginnie
On 04/26/12 08:10 AM, Jan Damborsky wrote:
Hi Ginnie,
thank you very much for review.
I agree with you. I removed save_etc_files() along with related
unit test
and replaced it with direct call to save_files_directories().
I didn't create save_list in __init() (instead file to be saved is
passed
directly as an argument to save_files_directories()), as that
better suits
other changes I made to address Karen's comments.
Being in that code, I also fixed another two CRs which are related:
7098714 system/network installed via GUI and text installer fails
pkg verify check
7093060 pre_pkg_img_mod needs a streamlined method for saving files
for later restoration by ICTs
I updated webrev accordingly:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7162079-2/webrev-2/
So far I have tested Sparc text installation, build of other images
is now in progress.
Jan
On 04/25/12 18:20, Virginia Wray wrote:
Hi Jan --
I only really have one comment. The rest looks ok.
pre_pkg_img_mod.py
-----------------------------
ln 144 save_etc_files function -- I was wondering....would it
make sense to
just get rid of this function. Instead, define the save_list in
the __init__
and then just call the save_files_directories function where
save_etc_files is called (at ln 730 and 787).
sinc that's the only thing the save_etc_files function does.
That's really my only comment, although if you choose to make this
change, then you
might be able to take advantage of the save_list in the test
setup. Instead of having
to create a list (self.pi_filelist), you could use the list in the
PrePkgImgMod class.
thanks,
ginnie
On 04/24/12 04:42 AM, Jan Damborsky wrote:
Hi,
I would appreciate code review of changes for
7162079 CPIO installation propagates install root password to the
target
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7162079/webrev/
Thank you,
Jan
Testing done:
* built text/AI/LiveCD install images using modified Distro Const.
Workarounds for 7162039 and7162553were applied on LiveCD.
* tested text, AI, LiveCD installations.
Verified that shadow(4) was restored from 'save' area in case
when CPIO transfer method was used for installation (text,
LiveCD).
* run unit tests (new unit test added for introduced
method PrePkgImgMod.save_etc_files()
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
