Karen,
Thanks for the review. I'll add another note to the CR.
-Drew
On 5/4/12 4:06 PM, Karen Tung wrote:
Hi Drew,
The changes look good to me.
As we discussed over IM, please update the bug to explain which recent
project introduced this dependency.
Thanks,
--Karen
On 05/ 4/12 01:51 PM, Drew Fisher wrote:
Good afternoon!
Could I get a couple of eyes on a simple code change:
7166613 <http://monaco.us.oracle.com/detail.jsf?cr=7166613> sysconfig
missing dependency on system/library/storage/snia-ima
The diffs are very small:
diff -r e9d4b6b42777 usr/src/pkg/manifests/system-library-install.mf
--- a/usr/src/pkg/manifests/system-library-install.mf Fri May 04
03:12:13 2012 -0600
+++ b/usr/src/pkg/manifests/system-library-install.mf Fri May 04
14:41:12 2012 -0600
@@ -280,3 +280,5 @@
depend type=require \
fmri=pkg:/system/library/[email protected],5.11-0.175.1.0.0.12.18901
depend type=require fmri=system/boot-environment-utilities
+# Add a dependency for libima.so
+depend type=require fmri=system/library/storage/snia-ima
What's happening here is sysconfig uses the engine. The engine uses
target/logical.py:Filesystem which forces the import of
target/physical.py. This in turn imports target/libima/ima.* which
has the ctypes mapping to /usr/lib/libima.so
We're not dependent on snia-ima right now, which means that zone
installs done later fail because zones uses sysconfig which import
libima which .. breaks.
The longer term solution here is to refactor the targets code so that
we have less dependency issues like this. Dave Marker and I have
discussed the possibility of taking the Target class out of
install_target/__init__.py to move it to it's own file but this level
of refactoring is quite complex and not suitable for
closed/restricted builds.
I checked the dependencies of snia-ima and there are no other
packages that we're not already using:
[mox:src] > pkg contents -r -m snia-ima | grep depend
depend fmri=pkg:/system/[email protected] type=require
depend fmri=consolidation/osnet/osnet-incorporation type=require
I'm not a packaging expert here, so if there's a better way to do
this, please let me know.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
