On 5/7/12 12:10 PM, Jack Schwartz wrote:
Hi Drew.
system-config/__init__.py: The else on 824 is not needed.
Also, I think the proposed fix for 7055372 would confuse users. A
"small" digit string (numerically less than 2 ** 64) would be rejected
but larger ones would be accepted. This seems like inconsistent
behavior to me. Telling add_props() the property type seems like it
would lend a better user experience.
If the user wants to force a specific type, they can use setprop():
def setprop(self, tag='propval', name=None, ptype=None, value=None):
'''Create a child SMFProperty with given name and value'''
This is for the case where we're trying to figure out the type on our
own. I feel adding a proptype argument to add_props() is unnecessary in
cases like the one you mention.
-Drew
Thanks,
Jack
On 05/ 7/12 09:31 AM, Drew Fisher wrote:
Good morning!
Could I please get a few eyes on a webrev for the following CRs:
7055372 <http://monaco.us.oracle.com/detail.jsf?cr=7055372> Installation
with very long host name failed at checkpoint apply-sysconfig
7074867 <http://monaco.us.oracle.com/detail.jsf?cr=7074867> truncated string
"System Configuration Interactive (SCI) tool will be" extracted to message source
7094123 <http://monaco.us.oracle.com/detail.jsf?cr=7094123> 'sysconfig configure
-c<dir>' flattens out given<dir> tree
7166308 <http://monaco.us.oracle.com/detail.jsf?cr=7166308> sysconfig
LDAP profile screen should default to profile name field not the 2nd field on screen
https://cr.opensolaris.org/action/browse/caiman/drewfish/sysconfig_fixes/webrev/
Testing done:
7055372 - verified the example hostname in the CR correctly toggles
back to 'astring'
7094123 - verified a similar example from the CR behaves correctly
all the way through sysconfig configure
7166308 - verfied the profile_name field is highlighted first on the
LDAP screen
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
